Brain

ceo-review-checklist

2 min read

🔍 CEO Code Review Checklist

Owner: J.A.R.V.I.S. (CEO / Hermes) When: After Tech Lead marks an issue as “done” Model: Claude Sonnet 5 or GPT-5.6 for reasoning-heavy reviews

The Review Flow

When a Tech Lead marks an issue done:

  1. Pull the latest code — cd /root/repos/<project> && git pull origin main
  2. Check the commit — git log -1 --stat to see what changed
  3. Review the diff — git diff HEAD~1 to see the actual changes
  4. Run the tests — python -m pytest tests/ -v
  5. Code review — Use a smarter model to check:
    • Does the code match the spec in the issue?
    • Are there obvious bugs or edge cases missed?
    • Is the code clean and maintainable?
    • Are tests comprehensive?
    • Any security concerns?
  6. Decision: Approve (close issue) or Reject (reopen with notes)

What To Look For

Correctness

  • Does it actually do what the issue asked?
  • Are edge cases handled (empty input, None, negative numbers)?
  • Does it match the acceptance criteria?

Test Quality

  • Are there tests for the happy path?
  • Are there tests for edge cases and error conditions?
  • Do tests actually assert meaningful things (not just “no error”)?

Code Quality

  • Clean, readable, follows conventions
  • No dead code, no commented-out blocks
  • Proper error handling
  • No hardcoded values that should be configurable

Security (even in sandbox)

  • No secrets in code
  • No dangerous input handling
  • No command injection vectors

Review Comment Format

## CEO Review

**Verdict:** ✅ Approved / ❌ Needs Changes

**Checks:**
- [x] Code matches spec
- [x] Tests pass (N tests)
- [x] Edge cases covered
- [x] Code is clean
- [x] Pushed to remote

**Notes:** [any observations or suggestions]

Escalation

  • If code is fundamentally broken → Reopen issue with specific failure points
  • If pattern of issues → Document in vault 03-lessons/
  • If architectural concern → Escalate to Pat via WhatsApp

Graph View